add License headers as a first-class review category#187
Merged
Conversation
potiuk
approved these changes
May 17, 2026
paulk-asert
added a commit
to paulk-asert/airflow-steward
that referenced
this pull request
May 17, 2026
…tooling and exclusion-masking cases PR apache#187 added "License headers" to the canonical category list and a section-anchor URL, but no rule body — making it the only framework-default category with neither an adopter source nor a criteria.md section. This adds the missing `## License headers` section so it matches its siblings (Third-party license compliance, Security model, Quality signals). The section is written as a deference-plus-judgement layer, not a re-implementation of apache-rat / pre-commit: - When a header check is in the status-check rollup, that tool is authoritative for mechanical presence/absence; Golden rule 8 + the CI precheck already block approve on its failure. The skill does not raise a duplicate "missing header" finding, and treats the project's tool config (not the policy page) as the source of truth for scope/exclusions. - Projects with no header tooling: the skill is the safety net and scans added/rewritten source files itself. - Exclusion-masking case: when the same PR both adds a header-tool exclusion entry and a file lacking an Apache header, CI passes green by construction and deference gives no coverage — the skill raises a finding asking the maintainer to confirm the exclusion is appropriate. - Judgement cases the tool cannot decide (mis-applied SPDX, wrong license, third-party header routing) are called out, closing the loop with the existing Third-party-license-compliance cross-ref. Generated-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
potiuk
pushed a commit
that referenced
this pull request
May 17, 2026
…tooling and exclusion-masking cases (#195) PR #187 added "License headers" to the canonical category list and a section-anchor URL, but no rule body — making it the only framework-default category with neither an adopter source nor a criteria.md section. This adds the missing `## License headers` section so it matches its siblings (Third-party license compliance, Security model, Quality signals). The section is written as a deference-plus-judgement layer, not a re-implementation of apache-rat / pre-commit: - When a header check is in the status-check rollup, that tool is authoritative for mechanical presence/absence; Golden rule 8 + the CI precheck already block approve on its failure. The skill does not raise a duplicate "missing header" finding, and treats the project's tool config (not the policy page) as the source of truth for scope/exclusions. - Projects with no header tooling: the skill is the safety net and scans added/rewritten source files itself. - Exclusion-masking case: when the same PR both adds a header-tool exclusion entry and a file lacking an Apache header, CI passes green by construction and deference gives no coverage — the skill raises a finding asking the maintainer to confirm the exclusion is appropriate. - Judgement cases the tool cannot decide (mis-applied SPDX, wrong license, third-party header routing) are called out, closing the loop with the existing Third-party-license-compliance cross-ref. Generated-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
pr-management-code-reviewskill had no "License headers" category. A PR that added a new source file without the standard Apache license header would pass the skill's Step 4 scan entirely unchecked — no finding, noREQUEST_CHANGESdisposition.This was confirmed by cross-checking the skill's category list against the ASF source headers policy (
https://www.apache.org/legal/src-headers.html), which requires every ASF source file to carry the standard Apache header. The requirement existed in ASF policy but had no corresponding check in the review framework.As a secondary finding during the fix,
review-flow.mdStep 4's hardcoded category list was also out of sync withcriteria.md— it enumerated 8 categories whilecriteria.mdlisted 11. The missing three ("Quality signals to check", "Commits and PRs", "Security model") have been added in the same pass.Changes
.claude/skills/pr-management-code-review/criteria.mdLicense headersto the canonical category list (between "Code quality" and "Testing"), matching the ordering inreview-flow.md..claude/skills/pr-management-code-review/review-flow.mdcriteria.md.projects/_template/pr-management-code-review-criteria.mdhttps://www.apache.org/legal/src-headers.html) as the default anchor.Testing
Structural validation
The
tools/skill-validatorsuite (test_real_repo_passes) was run against allSKILL.mdfiles post-change. Result: 1 passed, 0 failed.Functional dry-run against synthetic PR content
The skill was executed in
dry-runmode against a hand-constructed PR diff:airflow/utils/dag_bag_utils.py(missing license header) andtests/utils/test_dag_bag_utils.py(header present and correct).dag_bag_utils.py:1, raised amajorfinding citinghttps://www.apache.org/legal/src-headers.html, and generated asuggestionblock with the correct header text.REQUEST_CHANGES(1 major finding).suggestionblock the contributor can apply in one click.